[HttpClient][Mime] support overwriting form encoding#18002
Open
croensch wants to merge 4 commits intosymfony:6.3from
Open
[HttpClient][Mime] support overwriting form encoding#18002croensch wants to merge 4 commits intosymfony:6.3from
croensch wants to merge 4 commits intosymfony:6.3from
Conversation
croensch
commented
Mar 5, 2023
Contributor
|
Versionadded directive is missing. Can you please use named parameters and remove the null, null? Thanks |
carsonbot
changed the title
croensch
commented
May 12, 2023
Author
croensch
left a comment
croensch
left a comment
There was a problem hiding this comment.
@OskarStark you think this wording is okay?
croensch
commented
May 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not really relevant to the Mime / Email docs because that will use Base64 by default.
I've tried to keep it short, i'm not sure it's good though.
See PR symfony/symfony#49587 and issue symfony/symfony#49315