Skip to content

Show compact way to implement a compiler pass #19210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Show compact way to implement a compiler pass #19210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions service_container/compiler_passes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,17 @@ method in the extension)::
}
}

:doc:Implement process() directly in the bundle definition by extending AbstractBundle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not add a new paragraph here but instead let the MyBundle class from the example above also implement the CompilerPassInterface and the process() method and add a comment inside this method that a bundle can be a compiler pass itself (we already mention process() in the text above).

and implementing CompilerPassInterface.::

class SurvosApiGridBundle extends AbstractBundle implements CompilerPassInterface
{
// The compiler pass
public function process(ContainerBuilder $container): void
{

}

If you are using custom :doc:`service tags </service_container/tags>` in a
bundle then by convention, tag names consist of the name of the bundle
(lowercase, underscores as separators), followed by a dot, and finally the
Expand Down