[Cache] Add information about clock parameter in ArrayAdapter #20070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Aug 6, 2024
| // implementation of Psr\Clock\ClockInterface (e.g. Symfony\Component\Clock\Clock) | ||
| // or null. If clock is provided, cache items lifetime will be calculated | ||
| // based on time provided by this clock | ||
| $clock = null |
There was a problem hiding this comment.
I would shorten it a bit like this:
// optional implementation of the Psr\Clock\ClockInterface that will be used
// to calculate the lifetime of cache items (for example to get predictable
// lifetimes in tests)
$clock = null,
There was a problem hiding this comment.
Yes, this matches better the style of the existing docs, so I changed the original text by this while merging. Thanks.
|
Marcin, thanks and congrats on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20069