[Messenger] fix comment #20121
Merged
[Messenger] fix comment #20121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
friendly ping @wouterj |
|
Thanks Antoine! Let's merge this one as a temporary fix ... and, in addition, I created symfony-tools/docs-builder#180 in case we can fix this upstream in the code highlighter used in Symfony Docs. |
javiereguiluz
added a commit
to symfony-tools/docs-builder
that referenced
this pull request
Dec 31, 2024
This PR was merged into the main branch. Discussion ---------- Highlight nested PHP comments Related to symfony/symfony-docs#20121 This PR adds a failing test that shows the issue. This is the output change that would make test pass: ```diff - ), [ // wait - <span class="hljs-number">5</span> - seconds before processing + ), [ + <span class="hljs-comment">// wait 5 seconds before processing</span> ``` Commits ------- af7ee47 Allow one line comments in argument list 8f09af6 Highlight nested PHP comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comment "inside php code" render in wrong color
