Skip to content

[Serializer] Normalizer Callback params confusion: $innerObject should be called $attributeValue and $outerObject should be just $object #20161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2024
Merged

[Serializer] Normalizer Callback params confusion: $innerObject should be called $attributeValue and $outerObject should be just $object #20161

merged 1 commit into from
Aug 27, 2024

Conversation

thibaut22200
Copy link
Contributor

Closes #20080

@carsonbot carsonbot added this to the 7.2 milestone Aug 23, 2024
@javiereguiluz
Copy link
Member

@xabbuh is 7.2 the right branch for this or should we merge it in a lower branch? Thanks.

@javiereguiluz javiereguiluz modified the milestones: 7.2, 5.4 Aug 27, 2024
@javiereguiluz javiereguiluz changed the base branch from 7.2 to 5.4 August 27, 2024 06:31
@javiereguiluz javiereguiluz merged commit d8d38bc into symfony:5.4 Aug 27, 2024
3 checks passed
@javiereguiluz
Copy link
Member

At the end, I merged this in 5.4 branch and up.

Thibaut, thanks and congrats on your first Symfony Docs contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@OskarStark OskarStark Awaiting requested review from OskarStark

Assignees
No one assigned
Labels
Serializer Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@thibaut22200 @javiereguiluz @xabbuh @carsonbot