Skip to content

Conversation

novah77
Copy link
Contributor

@novah77 novah77 commented Sep 9, 2024

This commit fix the call to an undefined method named "setContentDisposition" of class "Symfony\Component\HttpFoundation\Response".

This commit fix the call to an undefined method  named "setContentDisposition" of class "Symfony\Component\HttpFoundation\Response".
@MrYamous
Copy link
Contributor

MrYamous commented Sep 9, 2024

Hello, few lines above we have $response = new BinaryFileResponse($file); and the sentence just before this code is mentioning this class where this method is defined then I think the code example is fine
What do you think about it ?

@novah77
Copy link
Contributor Author

novah77 commented Sep 10, 2024 via email

@javiereguiluz
Copy link
Member

Let's close as "won't fix" then, but we'll reword this if we receive more feedback in the future mentioning that this is confusing. Thanks.

@carsonbot carsonbot changed the title Fix call to an undefined method setContentDisposition() [HttpFoundation] Fix call to an undefined method setContentDisposition() Sep 10, 2024
@novah77 novah77 deleted the patch-1 branch September 11, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants