Skip to content

Conversation

javiereguiluz
Copy link
Member

Fixes #20243.

@wouterj
Copy link
Member

wouterj commented Sep 23, 2024

You're fast Javier. thank you!

I was thinking we might also want to document $output->isSilent() somewhere. E.g. I can think of a pattern where you write some information to a logger when a command is run in silent mode (if the command is ran both manually and programmatically). If we do it, it's good to mention that errors will always be logged to the logger by the Symfony framework integration.

@javiereguiluz
Copy link
Member Author

Wouter, you are right! I added some more content. Let me know if it's OK. Thanks.

@javiereguiluz
Copy link
Member Author

Let's merge this one and we can create other PRs if we want to change or improve things. Thanks!

@javiereguiluz javiereguiluz merged commit 4fcdb8f into symfony:7.2 Sep 27, 2024
3 checks passed
@javiereguiluz javiereguiluz deleted the fix_20243 branch September 27, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants