Skip to content

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Oct 14, 2024

Follows #20094 (comment).

@phansys phansys force-pushed the messenger_redis_ssl branch from 191b970 to f39f657 Compare October 14, 2024 17:44
======================= ===================================== =================================

The ``ssl`` option can be used to change requirements for the TLS channel, e.g. in tests:
The ``ssl`` option can be used to provide SSL context options (`php.net/context.ssl`_) for the TLS channel, e.g. in tests:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The ``ssl`` option can be used to provide SSL context options (`php.net/context.ssl`_) for the TLS channel, e.g. in tests:
The ``ssl`` option can be used to provide `SSL context options`_ for the TLS channel, e.g. in tests:

WDYT about this for better link integration in text ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could use the proposed variant if this keeps the reference intact to the PHP docs.

image

See:

SSL context options. See `php.net/context.ssl`_ for more information.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @MrYamous proposal is what we usually do in the docs. So, I changed this while merging. See 714113c

@javiereguiluz javiereguiluz merged commit 9ae9efe into symfony:6.4 Oct 15, 2024
3 checks passed
@javiereguiluz
Copy link
Member

Thanks Javier!

@phansys phansys deleted the messenger_redis_ssl branch October 15, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants