[Controller ] Update link to PHP docs for Validate filters/constants #20369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilETaylor
changed the title
xabbuh
approved these changes
Nov 7, 2024
javiereguiluz
force-pushed
the
patch-1
branch
from
ab0ea21 to
590225c
Compare
|
Good catch, thanks Phil. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strange one here on https://symfony.com/doc/current/controller.html#mapping-query-parameters-individually -
The link on Validate Filters is now a 404
The ENGLISH page https://www.php.net/manual/en/filter.filters.validate.php is now a 404
Its viewable in other languages (Ukraine for example) at https://www.php.net/manual/uk/filter.filters.validate.php
However ultimately I think it has moved to https://www.php.net/manual/en/filter.constants.php which contains the same kind of list - also available in other languages already, eg Ukraine https://www.php.net/manual/uk/filter.constants.php
Ultimately the Symfony docs are linking to a 404, and so either you accept this PR, or collectively we need to find and propose a different fix/url to fix the link to the 404 page.