Skip to content

Fix error_pages.rst setResponse() #20404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2024
Merged

Fix error_pages.rst setResponse() #20404

merged 1 commit into from
Nov 22, 2024

Conversation

Florian-Merle
Copy link
Contributor

I believe #13877 should not have been merged because setException has been replaced by setThrowable, not setResponse.

@carsonbot carsonbot added this to the 5.4 milestone Nov 21, 2024
chalasr
chalasr approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@OskarStark
Copy link
Contributor

Thanks for fixing this bug Florian.

@OskarStark OskarStark merged commit 29c83bd into symfony:5.4 Nov 22, 2024
3 checks passed
@Florian-Merle Florian-Merle deleted the fix/error_pages_setResponse branch November 22, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

+2 more reviewers

@mtarld mtarld mtarld approved these changes

@chalasr chalasr chalasr approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@Florian-Merle @OskarStark @xabbuh @mtarld @chalasr @carsonbot