[Mailer] Removing all n/as
#20436
Closed
[Mailer] Removing all n/as
#20436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Page: https://symfony.com/doc/current/mailer.html#using-a-3rd-party-transport Reason: The page is getting longer and longer... Besides, I would merge those 2 tables with the 3rd party providers; listing each one *twice* doesn't make much sense to me.
|
Why not 👍🏻 |
OskarStark
approved these changes
Dec 4, 2024
|
For 6.4 |
|
You mean I should merge the lists in 6.4? But there were new entries added in 7.2, isn't this going to be a merging nightmare? |
|
I disagree with this change. It's true that it looks like unnecessary information, but in my opinion, this is useful. If we show nothing, readers don't know if that option doesn't exist or if the docs need some update. But, if we explicitly say that something it's not available, then it's very clear that the docs checked this. |
|
I think I tend to agree with Javier. |
|
Makes sense @javiereguiluz Thanks for proposing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page: https://symfony.com/doc/current/mailer.html#using-a-3rd-party-transport
Reason: The page is getting longer and longer...
Besides, I would merge those 2 tables with the 3rd party providers; listing each one twice doesn't make much sense to me.