Skip to content

Conversation

daveharding
Copy link
Contributor

The $maxDepthHandler function might return NULL, but the return type is set to : string, which causes a TypeError to be thrown.

This change allows the $maxDepthHandler function to return null, by changing the return type to : ?string for this example.

@xabbuh xabbuh added this to the 6.4 milestone Dec 13, 2024
The $maxDepthHandler function might return NULL, but the return type is set to : string, which causes a TypeError to be thrown.

This change allows the $maxDepthHandler function to return null, by changing the return type to : ?string for this example.
@xabbuh
Copy link
Member

xabbuh commented Dec 16, 2024

Good catch, thanks @daveharding.

@xabbuh xabbuh merged commit e17ff0c into symfony:6.4 Dec 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants