Skip to content

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 25, 2025

The link is currently broken (see https://symfony.com/doc/7.3/serializer.html).

@carsonbot carsonbot added this to the 7.3 milestone Mar 25, 2025
@@ -1388,12 +1388,12 @@ normalizers (in order of priority):
want ``null`` instead, you can set the ``BackedEnumNormalizer::ALLOW_INVALID_VALUES`` option.

:class:`Symfony\\Component\\Serializer\\Normalizer\\NumberNormalizer`
This normalizer converts between :phpclass:`BcMath\\Number` or :phpclass:`GMP` objects and
This normalizer converts between :phpclass:`BcMath\Number` or :phpclass:`GMP` objects and
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OskarStark Does doctor-rst require an update to also handle symfony-tools/docs-builder#190?

Copy link
Contributor

@OskarStark OskarStark Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why class requires double slash, but phpclass doesn't. Don't they use the exact same rst feature?

Copy link
Contributor

@alamirault alamirault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xabbuh

Sorry for these mistakes

@wouterj
Copy link
Member

wouterj commented Apr 6, 2025

I've found why there is an inconsistency and propose to fix this on the docs-builder instead: symfony-tools/docs-builder#191

If we merge that one, we can close this.

@OskarStark
Copy link
Contributor

We merged the docs-builder PR

@xabbuh xabbuh closed this Apr 7, 2025
@xabbuh xabbuh deleted the pr-20782 branch April 7, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants