Skip to content

Add missing/helpful comment in code example #20867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add missing/helpful comment in code example #20867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions messenger.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2778,6 +2778,8 @@ provided in order to ease the declaration of these special handlers::
$ack->nack($e);
}
}

// Do something in batch that is costly (e.g. sending data to a 3rd party API).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the best place for this comment? Shouldn't it go to inside the previous foreach? Maybe I'm missing something. Thanks.

}

// Optionally, you can override some of the trait methods, such as the
Expand Down