Skip to content

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Apr 15, 2025

hello
RFC on such change: with a codebase and langage being more and more type hinted and less with phpdoc
and with ppl copying/getting inspired with the official doc
wdyt of such changes? keep it or trash it ? can we replicate elsewhere?

thank you

@javiereguiluz
Copy link
Member

My opinion about adding assert() calls in docs is 👎

I think it's a bit confusing for many newcomers and it's not a widespread practice for other developers, in my own experience.

But let's wait for more opinions about this. Thanks.

@OskarStark
Copy link
Contributor

OskarStark commented Apr 21, 2025

I agree, let's keep it like it is.

Thanks for proposing

@OskarStark OskarStark closed this Apr 21, 2025
@94noni 94noni deleted the patch-15 branch April 21, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants