[HtmlSanitizer] Fix method names #21216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

OskarStark merged 1 commit into 6.4 from html-sanitizer-method-names-6.4

Jul 23, 2025

Contributor

OskarStark commented Jul 18, 2025

Changed incorrect method names from allowed* to allow*:

allowedLinkSchemes() → allowLinkSchemes()
allowedLinkHosts() → allowLinkHosts()
allowedMediaSchemes() → allowMediaSchemes()
allowedMediaHosts() → allowMediaHosts()

These are the correct method names used in the HtmlSanitizerConfig class.

Fixes #21211

OskarStark requested a review from javiereguiluz

July 18, 2025 07:36

OskarStark added the bug label

carsonbot added the Status: Needs Review label

carsonbot added this to the 6.4 milestone

OskarStark added the HtmlSanitizer label

carsonbot changed the title ~~Fix HTML Sanitizer method names in documentation~~ [HtmlSanitizer] Fix HTML Sanitizer method names in documentation

OskarStark changed the title ~~[HtmlSanitizer] Fix HTML Sanitizer method names in documentation~~ [HtmlSanitizer] Fix method names

xabbuh requested changes

View reviewed changes

html_sanitizer.rst Outdated Show resolved Hide resolved

html_sanitizer.rst Outdated Show resolved Hide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

OskarStark commented

View reviewed changes

html_sanitizer.rst Outdated Show resolved Hide resolved

carsonbot added Status: Needs Review and removed Status: Needs Work labels

OskarStark commented

View reviewed changes

html_sanitizer.rst Outdated Show resolved Hide resolved

OskarStark commented

View reviewed changes

html_sanitizer.rst Outdated Show resolved Hide resolved

OskarStark commented

View reviewed changes

html_sanitizer.rst Outdated Show resolved Hide resolved

OskarStark commented

View reviewed changes

html_sanitizer.rst Outdated Show resolved Hide resolved

OskarStark commented

View reviewed changes

html_sanitizer.rst Outdated Show resolved Hide resolved

OskarStark requested review from stof and xabbuh

July 23, 2025 09:13

stof approved these changes

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels


          [HtmlSanitizer] Fix method names

0918b69

OskarStark force-pushed the html-sanitizer-method-names-6.4 branch from f2cd0d7 to 0918b69 Compare

July 23, 2025 09:23

OskarStark merged commit 4e9bdb1 into 6.4

6 checks passed

OskarStark deleted the html-sanitizer-method-names-6.4 branch

July 23, 2025 09:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug HtmlSanitizer Status: Reviewed