[DependencyInjection] Corrections and rephrasings #21347
Merged
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkolndeep
changed the title
xabbuh
reviewed
Sep 6, 2025
| ================== | ||
|
|
||
| Making a class's dependencies explicit and requiring that they be injected | ||
| Making a class's dependencies explicit and requiring that they must injected |
There was a problem hiding this comment.
Suggested change
| Making a class's dependencies explicit and requiring that they must injected | |
| Making a class's dependencies explicit and requiring that they must be injected |
There was a problem hiding this comment.
@xabbuh I corrected it.
xabbuh
reviewed
Sep 6, 2025
| dependency has been injected. By type-hinting, you'll get a clear error | ||
| immediately if an unsuitable dependency is injected. By type hinting | ||
| using an interface rather than a class you can make the choice of dependency | ||
| using an interface rather than a class you can make the choice of the dependency |
There was a problem hiding this comment.
@xabbuh Finally, I deleted the "the".
xabbuh
reviewed
Sep 6, 2025
| There are several ways that the dependencies can be injected. Each injection | ||
| point has advantages and disadvantages to consider, as well as different | ||
| ways of working with them when using the service container. | ||
| ways of working with when using the service container. |
There was a problem hiding this comment.
@xabbuh I finally put again them. It is ok.
xabbuh
reviewed
Sep 6, 2025
| Making a class's dependencies explicit and requiring that they must injected | ||
| into it is a good way of making a class more reusable, testable and decoupled | ||
| from others. | ||
| from the others. |
There was a problem hiding this comment.
Suggested change
| from the others. | |
| from other parts of the code. |
Maybe like this?
There was a problem hiding this comment.
@xabbuh Yes, I think it is nice. I replaced with your suggestion.
xabbuh
approved these changes
Sep 6, 2025
javiereguiluz
changed the title
javiereguiluz
force-pushed
the
corrections_and_rephrasings
branch
from
8f1f2f0 to
072f64e
Compare
|
Thanks Stephan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some corrections and rephrasings concerning the documentation.