[PropertyInfo] Improved the explanation of the with_constructor_extractor option #21431
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
approved these changes
Sep 29, 2025
xabbuh
reviewed
Sep 29, 2025
|
|
||
| The ``with_constructor_extractor`` option was introduced in Symfony 7.3. | ||
| The ``with_constructor_extractor`` option was introduced in Symfony 7.3 and | ||
| will be removed in Symfony 8.0. This temporary option was added because its |
There was a problem hiding this comment.
This looks wrong to me. The option won't be removed in 8.0. What changes is the default value, but you should still be able to disable the option to not register the constructor extractor.
There was a problem hiding this comment.
You are right. Sorry. I misread the code PR. I've just updated the description again. Thanks.
xabbuh
approved these changes
Sep 29, 2025
javiereguiluz
force-pushed
the
with_constructor_extractor_option
branch
from
a81b1c3 to
001263e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #21060 we're removing this config option, soI think we should better explain its purpose.