Add missing choice_lazy and choice_loader to EntityType inherited options#21982
Open
lacatoire wants to merge 1 commit intosymfony:7.4from
Open
Add missing choice_lazy and choice_loader to EntityType inherited options#21982lacatoire wants to merge 1 commit intosymfony:7.4from
lacatoire wants to merge 1 commit intosymfony:7.4from
Conversation
Collaborator
|
Hey! Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/ Cheers! Carsonbot |
carsonbot
changed the title
There was a problem hiding this comment.
Pull request overview
Updates the Symfony Form documentation for EntityType to correctly list missing inherited options from ChoiceType, addressing reported gaps in the “Inherited Options” section.
Changes:
- Add
choice_lazytoEntityType’s inherited options list. - Add
choice_loadertoEntityType’s inherited options list. - Reuse existing
.rst.incoption include files for consistency with other form type docs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+232
to
+235
| .. include:: /reference/forms/types/options/choice_lazy.rst.inc | ||
|
|
||
| .. include:: /reference/forms/types/options/choice_loader.rst.inc | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
choice_lazyandchoice_loaderto the EntityType's inherited options from ChoiceType.rst.incinclude files, consistent with how other inherited options are includedRelated to #20104 (re-check all form types inherited options).
Fixes #21855