Skip to content

Conversation

RobertErobert
Copy link

@RobertErobert RobertErobert commented Apr 8, 2017

Added a note that the examples comes from ButtonType::class. #6864

fixed typo
Forgot the dot at the end of the sentence :)
@HeahDude
Copy link
Contributor

HeahDude commented Apr 8, 2017

Hello @DJWindless I think it will be easier to review and merge if you do all the changes in one PR, either this one or #7772.

@RobertErobert
Copy link
Author

Hello @HeahDude, sorry for this. This is my first time with github and PR. Next time i will do better :)

@HeahDude
Copy link
Contributor

HeahDude commented Apr 8, 2017

Please don't be sorry :), thank you very much for improving the docs on your first contribution!

@javiereguiluz
Copy link
Member

I'm closing this as fixed by the alternative solution provided by #7824.

@DJWindless even if your pull request wasn't merged, it helped us notice this issue. So thanks a lot for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants