fix broken hash value of link #7965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. change http://symfony.com/doc/2.8/components/dependency_injection/compilation.html#components-di-separate-compiler-passes to http://symfony.com/doc/2.8/components/dependency_injection/compilation.html#creating-separate-compiler-passes Affects all upstream versions up to 3.3/3.4
javiereguiluz
approved these changes
Dec 23, 2017
|
I do not understand this change. Both URLs end with the same section being displayed for me. |
|
@xabbuh in [...]
.. _creating-a-compiler-pass:
.. _components-di-compiler-pass:
Execute Code During Compilation
-------------------------------
[...]
.. _components-di-separate-compiler-passes:
Creating Separate Compiler Passes
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[...]Both references are different ... and this PR changes the link from the first one to the second one. Is this correct? |
|
Thanks for the clarification. I was actually confused by the links from the PR description. |
xabbuh
approved these changes
Dec 31, 2017
|
@robertfausk thanks for this fix and congrats on your first Symfony Docs contribution |
javiereguiluz
added a commit
that referenced
this pull request
Jan 2, 2018
This PR was merged into the 2.8 branch. Discussion ---------- fix broken hash value of link E.g. change http://symfony.com/doc/2.8/components/dependency_injection/compilation.html#components-di-separate-compiler-passes to http://symfony.com/doc/2.8/components/dependency_injection/compilation.html#creating-separate-compiler-passes Affects all upstream versions up to 3.3/3.4 Commits ------- 540b3f0 Fixed a wrong reference cdcce28 fix broken hash value of link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. change http://symfony.com/doc/2.8/components/dependency_injection/compilation.html#components-di-separate-compiler-passes to
http://symfony.com/doc/2.8/components/dependency_injection/compilation.html#creating-separate-compiler-passes
Affects all upstream versions up to 3.3/3.4