Deprecated the web_profiler.position option #8472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't we just remove deprecated options in the past? |
|
I don't know ... but I guess we need to document deprecated versions and remove them in the first Symfony version which doesn't include them (master/4.0 in this case). |
|
@xabbuh that does sound a little bit familiar. But adding the option as deprecated and removing it in 4.0 (like we do with other things) makes sense to me. |
weaverryan
approved these changes
Nov 16, 2017
|
Thank you Javier. |
xabbuh
added a commit
that referenced
this pull request
Nov 16, 2017
|
as merging branches up already caused conflicts I removed these changes when merging into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #8466.