Fix passing arguments to "Client" constructor #9149
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Client" is expecting an instance of "CookieJar", not "Cookie"
|
@liviubalan thanks for fixing this error! This was wrong since the oldest maintained branch (2.7) so I merged on it. That's why GitHub may make it look as closed instead of merged ... but it's merged. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 28, 2018
This PR was submitted for the 3.4 branch but it was merged into the 2.7 branch instead (closes #9149). Discussion ---------- Fix passing arguments to "Client" constructor "Client" is expecting an instance of "CookieJar", not "Cookie" Commits ------- dc438d2 Fix passing arguments to "Client" constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Client" is expecting an instance of "CookieJar", not "Cookie"