Replace JS toolchain by asset-mapper when testing ux-turbo #2232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
asset-mapper-ftw
branch
4 times, most recently
from
1907c84 to
c7090d4
Compare
|
Curiously, this fails on PHP 8.3 but passes on 8.4 (deps=high). |
nicolas-grekas
force-pushed
the
asset-mapper-ftw
branch
2 times, most recently
from
38f6c29 to
b0f7da9
Compare
|
I will take a look tomorrow! |
Kocal
force-pushed
the
asset-mapper-ftw
branch
5 times, most recently
from
da14a70 to
2264ff2
Compare
|
Those issues were caused because the assets were not reachable with the webserver/browser ran by Panther: It was fixed by compiling assets with Now all that's left is this issue and we'll be good to go :) |
Super strange. I opened php/php-src#16194 because this looks like a PHP bug to me. |
nicolas-grekas
force-pushed
the
asset-mapper-ftw
branch
from
2264ff2 to
e4bd4f2
Compare
|
Thanks for the help @Kocal PR is ready. |
Kocal
approved these changes
Oct 3, 2024
carsonbot
added
Status: Reviewed
|
Nice one! Thanks Nicolas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🙊