[Autocomplete] Remove symfony/string dependency #2267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
smnandre
commented
Oct 12, 2024
smnandre
commented
- remove Symfony\String dependency (used only to get form short name)
- fix Attribute methods missing internal tag
smnandre
force-pushed
the
autocomplete/remove-string-component
branch
2 times, most recently
from
49cf5af to
ce9e0eb
Compare
Kocal
approved these changes
Oct 12, 2024
carsonbot
added
Status: Reviewed
smnandre
force-pushed
the
autocomplete/remove-string-component
branch
from
ff6f63d to
b9e3037
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.