Skip to content

Conversation

feymo
Copy link
Contributor

@feymo feymo commented Oct 14, 2024

Q A
Bug fix? no
New feature? no
Issues N/A
License MIT

Update LiveComponents documentation by removing the warning requiring Stimulus bundle (as it is now part of the package requirements)

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Oct 14, 2024
@feymo feymo force-pushed the docs/remove-live-components-warning branch from adee065 to 9c30895 Compare October 14, 2024 07:46
@Kocal
Copy link
Member

Kocal commented Oct 14, 2024

Merci Félix 👀

I've double-checked our packages and the LiveComponent is not the only one to have a hard requirement on symfony/stimulus-bundle and have a document telling people to install/configure the Stimulus Bundle. The other packages are:

  • Chart
  • Map
  • React
  • Svelte
  • Vue
  • Turbo

Can you remove the documentation from those packages as well please? 🙏🏻

/cc @smnandre we spoke about that some weeks/months ago :)

@feymo
Copy link
Contributor Author

feymo commented Oct 15, 2024

Thank you @Kocal for the double-check 👍🏼
Packages you've mentioned have also been updated :)

@Kocal Kocal changed the title docs(liveComponents) - remove stimulus-bundle warning Remove stimulus-bundle unecessary warning on documentation Oct 15, 2024
@Kocal Kocal changed the title Remove stimulus-bundle unecessary warning on documentation Remove stimulus-bundle unnecessary warning on documentation Oct 15, 2024
@Kocal Kocal force-pushed the docs/remove-live-components-warning branch from 24f3d35 to 494d7d4 Compare October 15, 2024 10:36
@Kocal
Copy link
Member

Kocal commented Oct 15, 2024

Thanks Félix :)

@Kocal Kocal merged commit 4f6de44 into symfony:2.x Oct 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Needs Review Needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants