[Autocomplete] Translate "Add ..." text with remote data setup #2279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
approved these changes
Oct 17, 2024
Member
Kocal
left a comment
Kocal
left a comment
There was a problem hiding this comment.
Makes sense to me, thanks :)
Could you update the Autocomplete's CHANGELOG please?
carsonbot
added
Status: Reviewed
Author
|
Changelog updated |
Member
|
Do you know why the tests are failing ? |
Author
|
No idea, looks like it is the same like in #2108 (comment) |
smnandre
changed the title
smnandre
approved these changes
Oct 20, 2024
Member
|
Thank you @jonasdekeukelaere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2108 the "Add..." translation has been added. But this only worked for non remote data setups. This PR makes it work for remote data setup too.
Also add translation for Dutch.