Skip to content

Test diff size (4) #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2024
Merged

Test diff size (4) #2332

merged 1 commit into from
Nov 3, 2024

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Nov 3, 2024

I want to see if #2331 works.

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Nov 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2024 •
edited
Loading

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

FileBefore (Size / Gzip)After (Size / Gzip)
Chartjs
controller.js 2.23 kB / 771 B 2.46 kB+11% 📈 / 914 B+19% 📈
Map
abstract_map_controller.d.ts 3 kB / 741 B Removed
Translator
translator_controller.js 9.17 kB / 2.27 kB 8.07 kB-12% 📉 / 2.09 kB-8% 📉

@Kocal
Copy link
Member Author

Kocal commented Nov 3, 2024 •
edited
Loading

Finally 🥹

But it does not show the .d.ts file being removed, gonna investigate. The title is wrong tho

@Kocal Kocal merged commit c5b6bdf into symfony:2.x Nov 3, 2024
2 of 3 checks passed
@Kocal Kocal added the DX label Nov 3, 2024
@Kocal Kocal deleted the test-diff-4 branch November 3, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DX Status: Needs Review Needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kocal @carsonbot