Skip to content

[Doc] Revert some wrong changes in Twig Component docs #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz wants to merge 1 commit into from
Closed

[Doc] Revert some wrong changes in Twig Component docs #2437

javiereguiluz wants to merge 1 commit into from

Conversation

@javiereguiluz
Copy link
Member

@javiereguiluz javiereguiluz commented Dec 10, 2024

Q A
Bug fix? no
New feature? no
Issues -
License MIT

Reverts #2432

@javiereguiluz javiereguiluz added the Documentation Improvements or additions to documentation label Dec 10, 2024
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Dec 10, 2024
@javiereguiluz javiereguiluz mentioned this pull request Dec 10, 2024
Merged
@smnandre
Copy link
Member

smnandre commented Dec 10, 2024

I personally love this kind of do/don't code snippet and feel they are great for this kind of needs with non-intuitive answers.

Maybe we could keep the example and just rephrasing the introduction paragraph ? You know that more than me but maybe something like "macro cannot work in this that and those situations. To call a macro a component, you need to ... " ?

@smnandre smnandre mentioned this pull request Dec 11, 2024
Merged
@smnandre
Copy link
Member

smnandre commented Dec 11, 2024

@javiereguiluz Made an alternative PR if you find it ok!

@javiereguiluz
Copy link
Member Author

javiereguiluz commented Dec 11, 2024

Closing in favor of #2444.

javiereguiluz added a commit that referenced this pull request Dec 12, 2024
@javiereguiluz
minor #2444 [TwigComponent] Update using macro docs (smnandre)
dec3eb3 
This PR was merged into the 2.x branch.

Discussion
----------

[TwigComponent] Update using macro docs

Alternative to #2437

Commits
-------

d036498 [TwigComponent] Update using macro docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Documentation Improvements or additions to documentation Status: Needs Review Needs to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@javiereguiluz @smnandre @carsonbot