Skip to content

[Autocomplete] Fix invalid createQueryBuilder code example #2470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smnandre merged 2 commits into from
Feb 22, 2025
Merged

[Autocomplete] Fix invalid createQueryBuilder code example #2470

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27e539b
replace undefined $qb
tacman Dec 29, 2024
c028c19
Update index.rst
smnandre Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Autocomplete/doc/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ the consequent renders, the default ``query_builder`` will be used::
->add('food', FoodAutocompleteField::class, [
'query_builder' => function (EntityRepository $er) {
return $er->createQueryBuilder('o')
->andWhere($qb->expr()->notIn('o.id', [$currentFoodId]));
->andWhere($er->createQueryBuilder()->expr()->notIn('o.id', [$currentFoodId]));
Copy link
Member

@smnandre smnandre Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

I think we should use the same style than later in the file (L369..) as i fear calling createQueryBuilder twice could be confusing.

                       $qb = $er->createQueryBuilder('o');
                       
                       return $qb->andWhere($qb->expr()->notIn('o.id', [$currentFoodId]));

Copy link
Member

@smnandre smnandre Feb 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ended up doing it :)

};
])
;
Expand Down
Loading