Skip to content

Conversation

@dbu
Copy link
Contributor

@dbu dbu commented Mar 30, 2025

Q A
Bug fix? no
New feature? no
Docs? yes
Issues -
License MIT

Make installing user notice that they might want to install the optional dependencies.

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Mar 30, 2025
@dbu dbu changed the title use the composer suggest section for optional dependencies [Icons] use the composer suggest section for optional dependencies Mar 30, 2025
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in symfony/symfony packages, we don't use suggest but here, if it helps someone, I think it's ok.

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Mar 30, 2025
@Kocal Kocal added the Icons label Mar 30, 2025
@dbu
Copy link
Contributor Author

dbu commented Mar 30, 2025

yeah i wondered and saw symfony/symfony is not using them. imho it would be helpful here, especially the http-client which will probably be needed for a good part of the users.

@smnandre
Copy link
Member

smnandre commented Apr 2, 2025

I'm not sure to remember the reason ... maybe @kbond @weaverryan or @nicolas-grekas ?

In all manner we won't change this for a single repository, so the question is more "do we want to add composer suggest to UX packages"

We could also add http-client contracts here and throw at runtime if no concrete implementation is available ?

@nicolas-grekas
Copy link
Member

We don't use that because it's just noise. composer won't display suggestions by default anymore for this reason. Every packages can add stuff there and this is a mess very quickly.

@nicolas-grekas
Copy link
Member

BTW: composer/composer#12354

@dbu
Copy link
Contributor Author

dbu commented Apr 2, 2025

composer won't display suggestions by default anymore

i was not aware of that. then imho lets drop this. i let you close it, in case there is still need for some discussion.

@kbond
Copy link
Member

kbond commented Apr 2, 2025

Ah ok, I wasn't aware of the reason. TIL

@kbond kbond closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Icons Status: Reviewed Has been reviewed by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants