Skip to content

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Apr 29, 2025

WIP

@carsonbot carsonbot added Bug Bug Fix Feature New Feature Status: Needs Review Needs to be reviewed labels Apr 29, 2025
@94noni 94noni changed the title Update RecipeFileTree.php [RFC] Update RecipeFileTree removing webpack from homepage Apr 29, 2025
@smnandre
Copy link
Member

If we do this we should remove package.json too

@94noni
Copy link
Contributor Author

94noni commented Apr 30, 2025

Would you like I take care of this ?
Boot a new bare project and only install stimulus and assetmapper
Thats mostly the rationale of this pr

@Kocal
Copy link
Member

Kocal commented Apr 30, 2025

rfc: isnt webpack replaces by asset-mapper ?

No, both tools are equivalent but not identical at all, and fulfill different needs.

Symfony UX also targets Webpack Encore, not only the AssetMapper.

I'm a little disappointed to see it disappear like this, and I would be in favor to re-add it on the homepage, something like:

# If you use the Symfony AssetMapper:
$ composer require symfony/asset-mapper symfony/stimulus-bundle

# Or, if you use Symfony Webpack Encore:
$ composer require symfony/webpack-encore symfony/stimulus-bundle

Keep files package.json and webpack.config.js but add a prefix like When using Webpack Encore, ...

WDYT?

@Kocal Kocal added Documentation Improvements or additions to documentation and removed Bug Bug Fix Feature New Feature labels Apr 30, 2025
@94noni
Copy link
Contributor Author

94noni commented Apr 30, 2025

I got you, oki I will see if I can come with a proper rewrite for both usecases/installs 👍🏻
I was just surprise reading only asset mapper on the current composer install and seeing this webpack file :)

@94noni 94noni changed the title [RFC] Update RecipeFileTree removing webpack from homepage [WIP] Update homepage install documenting both assetmapper and webpack from homepage Apr 30, 2025
@94noni 94noni changed the title [WIP] Update homepage install documenting both assetmapper and webpack from homepage [WIP] Update homepage install documenting both assetmapper and webpack Apr 30, 2025
@smnandre
Copy link
Member

smnandre commented May 4, 2025

It has been removed for a reason: show the simplicity of install

As this page will soon_-ish_ be a relic of the past, i agree whatever you want here :)

@94noni
Copy link
Contributor Author

94noni commented May 4, 2025

oki lets not do work for nothing, lets close :)

@94noni 94noni closed this May 4, 2025
@94noni 94noni deleted the patch-2 branch May 4, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation Status: Needs Review Needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants