-
-
Notifications
You must be signed in to change notification settings - Fork 383
[Site][Toolkit] Add manual installation steps for Component installation (and some website tweaks) #2716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[Site][Toolkit] Add manual installation steps for Component installation (and some website tweaks) #2716
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3b6a11b
[Site] Rename CodePreview_Tabs to Toolkit_Tabs, extract Toolkit's doc…
Kocal 5a6a89a
[Site] Add manual installation steps for Toolkit kits's components
Kocal 2379c89
[Site] Fix Terminal component styles, ensure it does not grow, and di…
Kocal 948abe5
[Site] Refactor and use the CodeBlockRenderer::highlightCode() method…
Kocal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,14 +12,13 @@ | |
namespace App\Service\CommonMark; | ||
|
||
use App\Service\CommonMark\Extension\CodeBlockRenderer\CodeBlockRenderer; | ||
use App\Service\Toolkit\ToolkitService; | ||
use League\CommonMark\CommonMarkConverter; | ||
use League\CommonMark\Extension\CommonMark\Node\Block\FencedCode; | ||
use League\CommonMark\Extension\ExternalLink\ExternalLinkExtension; | ||
use League\CommonMark\Extension\FrontMatter\FrontMatterExtension; | ||
use League\CommonMark\Extension\Mention\MentionExtension; | ||
use Symfony\Component\DependencyInjection\Attribute\AsDecorator; | ||
use Symfony\Component\HttpFoundation\UriSigner; | ||
use Symfony\Component\Routing\Generator\UrlGeneratorInterface; | ||
|
||
/** | ||
* @author Kevin Bond <[email protected]> | ||
|
@@ -28,8 +27,7 @@ | |
final class ConverterFactory | ||
{ | ||
public function __construct( | ||
private readonly UrlGeneratorInterface $urlGenerator, | ||
private readonly UriSigner $uriSigner, | ||
private readonly ToolkitService $toolkitService, | ||
) { | ||
} | ||
|
||
|
@@ -57,7 +55,7 @@ public function __invoke(): CommonMarkConverter | |
->addExtension(new ExternalLinkExtension()) | ||
->addExtension(new MentionExtension()) | ||
->addExtension(new FrontMatterExtension()) | ||
->addRenderer(FencedCode::class, new CodeBlockRenderer($this->urlGenerator, $this->uriSigner)) | ||
->addRenderer(FencedCode::class, new CodeBlockRenderer($this->toolkitService)) | ||
; | ||
|
||
return $converter; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this one, but I don't really see why you would want to hide a scrollbar, as it reduce accessibility and UX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this related to Toolkit ? Any page i can see the problem ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes and no, I wanted to display a scroll bar when necessary, but I couldn't understand why this code exists.
You can check the "Alert" component page, by unfolding the files from "manual installation" section, it contains a Terminal with a veryyy long and unbreakable line.
You can also check other parts of the website where a Terminal is displayed, to confirm it didn't break things. 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it broke things at a time, two scrollbars were displayed. Testing on mac often gives a false impression, as macOS hide scrollbars per default.
But let's see and we will be able to fix if there were any pb
👍 :