Skip to content

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented May 15, 2025

Q A
Bug fix? yes
New feature? no
Docs? no
Issues Fix #2737
License MIT

I tried to re-use yarn version (...) commands, but that's a mess and I don't really understand why it does not work as expected 😬 (I can't wait to use pnpm :D)

So, let's use another solution which replace "workspace:*" by the new version (e.g.: 2.25.0) in package.json from our workspaces.
Running the macOS equivalent command yarn workspaces foreach -pA exec "sed -i '' 's/\"workspace:\*\"/\"2.25.0\"/g' package.json" produces this result:

diff --git a/src/Map/src/Bridge/Google/assets/package.json b/src/Map/src/Bridge/Google/assets/package.json
index 6c0fea00d9b..649b3db6414 100644
--- a/src/Map/src/Bridge/Google/assets/package.json
+++ b/src/Map/src/Bridge/Google/assets/package.json
@@ -50,7 +50,7 @@
     "devDependencies": {
         "@googlemaps/js-api-loader": "^1.16.6",
         "@hotwired/stimulus": "^3.0.0",
-        "@symfony/ux-map": "workspace:*",
+        "@symfony/ux-map": "2.25.0",
         "@types/google.maps": "^3.55.9"
     }
 }
diff --git a/src/Map/src/Bridge/Leaflet/assets/package.json b/src/Map/src/Bridge/Leaflet/assets/package.json
index d89d17d64e4..ad74dedb2bd 100644
--- a/src/Map/src/Bridge/Leaflet/assets/package.json
+++ b/src/Map/src/Bridge/Leaflet/assets/package.json
@@ -49,7 +49,7 @@
     },
     "devDependencies": {
         "@hotwired/stimulus": "^3.0.0",
-        "@symfony/ux-map": "workspace:*",
+        "@symfony/ux-map": "2.25.0",
         "@types/leaflet": "^1.9.12",
         "leaflet": "^1.9.4"
     }

@carsonbot carsonbot added Bug Bug Fix Status: Needs Review Needs to be reviewed labels May 15, 2025
@Kocal Kocal requested review from kbond and smnandre May 15, 2025 04:28
@Kocal Kocal force-pushed the fix-2737-npm-map branch from 2cbb56e to 091c729 Compare May 16, 2025 20:06
@Kocal Kocal merged commit d4e7e8e into symfony:2.x May 16, 2025
84 of 86 checks passed
@Kocal Kocal deleted the fix-2737-npm-map branch July 20, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Bug Fix Status: Needs Review Needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Map] NPM install does not working due to workspace url type

2 participants