-
-
Notifications
You must be signed in to change notification settings - Fork 383
Use singular folder pattern like other PHP components codes #2743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Every component consists of (1) a class:: | ||
|
||
// src/Twig/Components/Alert.php | ||
// src/Twig/Component/Alert.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// src/Twig/Component/Alert.php | |
// src/Twig/Component/Alert.php |
Something we will discuss in 3.0 .. but i totally agree.
To be fair, i even think we should use src/Component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i do have "devland codebase" component (relatively to symfony component)
having them at root level with "twig component" seems wrong to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for the namespace (but not now)
👎 for the template folder
top for php file and ok for twig file makes sens |
If we want to be iso everywhere, it also means that we must:
|
@Kocal thx ! I can work on it but please before assert to me that its desired so i wont lost my time and yours as well :) |
I don't think it is the time |
copy that, thx for being transparent ! |
opening this PR mostly as RFC
other code in sf document to create special code (messenger message, event listener|subscriber, etc) inside folders in singular form not plural
does It makes sens for twig component to follow this pattern ?