Skip to content

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented May 16, 2025

Q A
Bug fix? no
New feature? no
Docs? no
Issues Fix coherence pattern naming
License MIT

opening this PR mostly as RFC
other code in sf document to create special code (messenger message, event listener|subscriber, etc) inside folders in singular form not plural
does It makes sens for twig component to follow this pattern ?

@carsonbot carsonbot added RFC RFC = Request For Comments (proposals about features that you want to be discussed) Status: Needs Review Needs to be reviewed labels May 16, 2025
Every component consists of (1) a class::

// src/Twig/Components/Alert.php
// src/Twig/Component/Alert.php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// src/Twig/Component/Alert.php
// src/Twig/Component/Alert.php

Something we will discuss in 3.0 .. but i totally agree.

To be fair, i even think we should use src/Component

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do have "devland codebase" component (relatively to symfony component)
having them at root level with "twig component" seems wrong to me

Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the namespace (but not now)

👎 for the template folder

@94noni
Copy link
Contributor Author

94noni commented May 17, 2025

top for php file and ok for twig file makes sens
will rewrite this PR on the php codebase side 👍🏻

@94noni 94noni changed the title [RFC] use singular folder pattern like other components codes Use singular folder pattern like other components codes May 19, 2025
@94noni 94noni requested a review from Kocal as a code owner May 19, 2025 06:55
@94noni 94noni changed the title Use singular folder pattern like other components codes Use singular folder pattern like other PHP components codes May 19, 2025
@Kocal
Copy link
Member

Kocal commented May 19, 2025

If we want to be iso everywhere, it also means that we must:

@94noni
Copy link
Contributor Author

94noni commented May 19, 2025

@Kocal thx ! I can work on it but please before assert to me that its desired so i wont lost my time and yours as well :)

@smnandre
Copy link
Member

I don't think it is the time

@94noni
Copy link
Contributor Author

94noni commented May 19, 2025

copy that, thx for being transparent !
will revisit for 3.x 🤞🏻

@94noni 94noni closed this May 19, 2025
@94noni 94noni deleted the patch-2 branch May 19, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RFC RFC = Request For Comments (proposals about features that you want to be discussed) Status: Needs Review Needs to be reviewed TwigComponent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants