Skip to content

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented May 28, 2025

Q A
Bug fix? no
New feature? no
Docs? no
Issues Fix #...
License MIT

In #2607, https://github.com/symfony/ux/actions/runs/15297531864/job/43030093028?pr=2607 is shown as failed because step Run Encore (dev), but in reality it fails before but that's not shown:
image

With this change (which also remove a dependency), I hope the error to be well shown

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label May 28, 2025
@Kocal Kocal merged commit 13b40f4 into 2.x May 28, 2025
41 of 43 checks passed
@norkunas
Copy link
Contributor

you now lost caching dependencies which was abstracted away :)

@kbond kbond deleted the Kocal-patch-1 branch May 30, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants