Skip to content

[Toolkit] Remove Kit::$uxIcon, make icons internal to the website #2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2025
Merged

[Toolkit] Remove Kit::$uxIcon, make icons internal to the website #2807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Toolkit/kits/shadcn/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@
"name": "Shadcn UI",
"description": "Component based on the Shadcn UI library, one of the most popular design systems in JavaScript world.",
"license": "MIT",
"homepage": "https://ux.symfony.com/components",
"ux-icon": "simple-icons:shadcnui"
"homepage": "https://ux.symfony.com/components"
}
1 change: 0 additions & 1 deletion src/Toolkit/src/Kit/KitFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ public function createKitFromAbsolutePath(string $absolutePath): Kit
homepage: $manifest['homepage'] ?? throw new \InvalidArgumentException('Manifest file is missing "homepage" key.'),
license: $manifest['license'] ?? throw new \InvalidArgumentException('Manifest file is missing "license" key.'),
description: $manifest['description'] ?? null,
uxIcon: $manifest['ux-icon'] ?? null,
);

$this->kitSynchronizer->synchronize($kit);
Expand Down
2 changes: 1 addition & 1 deletion ...om/assets/icons/simple-icons/shadcnui.svg → ...mfony.com/assets/icons/toolkit/shadcn.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 3 additions & 5 deletions ux.symfony.com/templates/ux_packages/toolkit.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,9 @@ tree templates/components
<div class="mt-5 shadow-blur shadow-blur--rainbow shadow-blur--opacity-20" style="display: grid; gap: 2rem; grid-template-columns: repeat(auto-fill, minmax(min(100%, 420px), 1fr));">
{% for kit_id, kit in kits %}
<div class="PackageBox">
{% if kit.uxIcon %}
<div class="PackageBox_logo">
<twig:ux:icon name="{{ kit.uxIcon }}" alt="{{ kit.name }}" style="color: #fff; width: 50%; height: 50%;" />
</div>
{% endif %}
<div class="PackageBox_logo">
<twig:ux:icon name="toolkit:{{ kit_id }}" alt="{{ kit.name }}" style="color: #fff; width: 50%; height: 50%;" />
</div>
<div class="PackageBox_content">
<h2 class="PackageBox_title">
<a href="{{ path('app_toolkit_kit', {kitId: kit_id}) }}" class="PackageBox_link">{{ kit.name }}</a>
Expand Down
Loading