[Icons] Change xmlns attribute of downloaded icons to http://www.w3.org/2000/svg
#2959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not know that... w3c/svgwg#738 👍 @roverwolf Could you also change the UX toolkit affected tests? |
|
@smnandre Toolkit snapshots have been updated in the PR. Sorry, I had only checked the tests in the Icons component. |
|
PHP 8.4 failures unrelated (autocomplete) |
|
Thank you @roverwolf! |
smnandre
added
Status: Reviewed
smnandre
approved these changes
Jul 30, 2025
Kocal
approved these changes
Jul 30, 2025
|
Interesting, I didn't know this was so subtile |
Kocal
changed the title
xmlns attribute of downloaded icons to http://www.w3.org/2000/svg
Kocal
force-pushed
the
feat/fix_xmlns_attribute
branch
from
f9c9da3 to
bdf6270
Compare
|
Thank you @roverwolf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the xmlns attribute to be
http://www.w3.org/2000/svgfor icons imported usingconsole ux:icons:importso that the icons will correctly render in browsers and can be viewed by other image tools.