-
-
Notifications
You must be signed in to change notification settings - Fork 375
[Toolkit] Rework kits architecture, change term for "recipe" #2986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kocal
wants to merge
21
commits into
symfony:2.x
Choose a base branch
from
Kocal:toolkit-rework-component-for-recipe
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,503
−2,681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2133dc4
to
522b813
Compare
Kocal
commented
Aug 11, 2025
Kocal
commented
Aug 11, 2025
@@ -49,7 +49,7 @@ For example, if you want to install a `Button` component, you will find the foll | |||
|
|||
.. code-block:: terminal | |||
$ php bin/console ux:toolkit:install-component Button --kit=<kitName> | |||
$ php bin/console ux:install Button --kit=<kitName> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command ux:toolkit:install-component
has been renamed to ux:install
, cc @smnandre
5451620
to
50d3079
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This big PR modify the kits architecture from Toolkit, I get a lot of inspiration from Symfony Recipes and I think we are on something really really good.
The actual architecture was too coupled to a Symfony application structure, which made things easy for the website but not for working on "Recipes" (previously known as Components").
Before:
after:
Now, everything under
kits/*/
is a recipe. There is noAsset\Component
norAsset\StimulusController
anymore, everything was simplified a lot.A Recipe:
manifest.json
file, for describing its name, description, some dependencies (either PHP packages or other Recipes, which files to copy (and where), its type (either acomponent
, or something else in the future), etc...EXAMPLES.md
file, it's mainly internal for the WebsiteThe CLI still works as expected:
Enregistrement.de.l.ecran.2025-08-11.a.00.47.53.mov
The website too:
Enregistrement.de.l.ecran.2025-08-11.a.00.49.47.mov