Skip to content

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Aug 28, 2025

Q A
Bug fix? yes
New feature? no
Docs? no
Issues Fix #...
License MIT

Follows #2673

Related to https://symfony-devs.slack.com/archives/C01FN4EQNLX/p1756395137633869?thread_ts=1756320013.552729&cid=C01FN4EQNLX, I believe this is the ultimate last fix for the X-Live-Url generation based on LiveProp 😅

I confirm that in <2.28, the URL query params were using the fieldName value from LiveProp if available, but we missed it (I didn't even know about that, the feature is not documented).

@Kocal Kocal self-assigned this Aug 28, 2025
@carsonbot carsonbot added Bug Bug Fix LiveComponent Status: Needs Review Needs to be reviewed labels Aug 28, 2025
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Aug 28, 2025
@Kocal Kocal force-pushed the fix-live-component-new-url-field-name branch from 883dbaf to 25c3e13 Compare August 28, 2025 20:30
@Kocal Kocal requested review from kbond and smnandre August 28, 2025 20:30
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Reviewed Has been reviewed by a maintainer labels Aug 28, 2025
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Aug 28, 2025
@Kocal Kocal merged commit bb9a7e8 into symfony:2.x Aug 29, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix LiveComponent Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants