Add doc for E2E steps + minor modifications #3086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
raphael-geffroy
commented
Sep 18, 2025
raphael-geffroy
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| Docs? | yes |
| Issues | Fix #3039 |
| License | MIT |
carsonbot
changed the title
|
@Kocal tried to create the requested doc, tell me what I can adjust so it fits with your needs 🙏 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for interactive browser testing by introducing a new test:browser:ui npm script across all UX packages and enhances the documentation to guide contributors on E2E testing workflows.
- Adds
test:browser:uiscript to all package.json files for interactive browser testing with Playwright UI - Updates contribution documentation with comprehensive E2E testing guidelines
- Fixes an incorrect import path example in the Playwright base configuration
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Multiple package.json files | Added test:browser:ui script for interactive browser testing |
| CONTRIBUTING.md | Added comprehensive E2E testing documentation and clarified unit testing workflow |
| playwright.config.base.ts | Fixed incorrect import path in code example comment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Kocal
force-pushed
the
docs/e2e-contribution-documentation
branch
from
277e8b3 to
728d4e5
Compare
Kocal
changed the title
carsonbot
changed the title
Kocal
force-pushed
the
docs/e2e-contribution-documentation
branch
from
728d4e5 to
ceefa1d
Compare
|
I did some modifications to make it more "friendly", and also added Unit test section as well. |
Kocal
added a commit
that referenced
this pull request
Sep 20, 2025
…ultiples checks for packages definition (Kocal) This PR was merged into the 2.x branch. Discussion ---------- Refactor "test_package.sh" to its original purpose, add multiples checks for packages definition | Q | A | -------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md --> | Documentation? | no <!-- required for new features, or documentation updates --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Following the minor changes from #3086 Commits ------- 4949e62 Refactor "test_package.sh" to its original purpose, add multiples checks for packages definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.