Skip to content

[Docs] Fix composer config to avoid modifying package.json automatically #3091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2025
Merged

[Docs] Fix composer config to avoid modifying package.json automatically #3091

merged 1 commit into from
Sep 21, 2025

Conversation

Crovitche-1623
Copy link
Contributor

@Crovitche-1623 Crovitche-1623 commented Sep 20, 2025 •
edited
Loading

Q A
Bug fix? yes
New feature? no
Deprecations? no
Documentation? yes
Issues Fix #3092
License MIT

@Kocal

@carsonbot carsonbot added Bug Bug Fix Status: Needs Review Needs to be reviewed labels Sep 20, 2025
@carsonbot carsonbot changed the title docs: fix composer config to avoid modifying package.json automatically docs: fix composer config to avoid modifying package.json automatically Sep 20, 2025
smnandre
smnandre approved these changes Sep 21, 2025
View reviewed changes
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you very much!

(nitpicking here.. but i would call this a --very impactful-- documentation fix, but not a bug)

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Sep 21, 2025
@smnandre smnandre added Documentation Improvements or additions to documentation and removed Bug Bug Fix labels Sep 21, 2025
@smnandre smnandre changed the title docs: fix composer config to avoid modifying package.json automatically [Docs] Fix composer config to avoid modifying package.json automatically Sep 21, 2025
@Kocal
Copy link
Member

Kocal commented Sep 21, 2025

Thank you @Crovitche-1623.

@Kocal Kocal merged commit a336938 into symfony:2.x Sep 21, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smnandre smnandre smnandre approved these changes

@Kocal Kocal Awaiting requested review from Kocal Kocal is a code owner

Assignees
No one assigned
Labels
Documentation Improvements or additions to documentation Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: The composer config does not work as expected
4 participants
@Crovitche-1623 @Kocal @smnandre @carsonbot