[Map] Display warning when trying to define a custom icon for a Marker that already has an Icon
#3118
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ker0x
force-pushed
the
fix/issue-3116-bridge-options-icon
branch
2 times, most recently
from
2a76425 to
ecaa959
Compare
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
|||||||||||||||
|
Following #3116 (comment), I suggest instead log a warning message if we saw that the user tried to create an icon from the JavaScript side (through |
ker0x
force-pushed
the
fix/issue-3116-bridge-options-icon
branch
from
ecaa959 to
fbe1c48
Compare
ker0x
changed the title
|
I updated the PR to trigger a warning, as you suggested 👍! |
|
Should this be done on the PHP part ? |
|
No because we want to verify that the user, through a Stimulus Controller, tried to add an icon by itself with |
Kocal
force-pushed
the
fix/issue-3116-bridge-options-icon
branch
from
fbe1c48 to
b3d5c4d
Compare
Kocal
changed the title
Marker that already has an Icon
ker0x
commented
Oct 4, 2025
Comment on lines
3
to
6
| ## 2.30 | ||
|
|
||
| - Ensure compatibility with PHP 8.5 | ||
| - Display a warning when trying to define `bridgeOptions.content` for a `Marker` that already has an `Icon` |
There was a problem hiding this comment.
Suggested change
| ## 2.30 | |
| - Ensure compatibility with PHP 8.5 | |
| - Display a warning when trying to define `bridgeOptions.content` for a `Marker` that already has an `Icon` | |
| ## 2.31 | |
| - Display a warning when trying to define `bridgeOptions.content` for a `Marker` that already has an `Icon` | |
| ## 2.30 | |
| - Ensure compatibility with PHP 8.5 |
2.30 has already been release!
Comment on lines
3
to
6
| ## 2.30 | ||
|
|
||
| - Ensure compatibility with PHP 8.5 | ||
| - Display a warning when trying to define `bridgeOptions.icon` for a `Marker` that already has an `Icon` |
There was a problem hiding this comment.
Suggested change
| ## 2.30 | |
| - Ensure compatibility with PHP 8.5 | |
| - Display a warning when trying to define `bridgeOptions.icon` for a `Marker` that already has an `Icon` | |
| ## 2.31 | |
| - Display a warning when trying to define `bridgeOptions.icon` for a `Marker` that already has an `Icon` | |
| ## 2.30 | |
| - Ensure compatibility with PHP 8.5 |
…er` that already has an `Icon`
Kocal
force-pushed
the
fix/issue-3116-bridge-options-icon
branch
from
b3d5c4d to
6a6b230
Compare
|
Thank you @ker0x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional checks before creating the icon for a marker