Skip to content

Conversation

alexislefebvre
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Deprecations? no
Documentation? yes
Issues -
License MIT

This looked weird:

image

@carsonbot carsonbot added Documentation Improvements or additions to documentation Status: Needs Review Needs to be reviewed labels Oct 9, 2025
@carsonbot carsonbot changed the title TwigComponent: remove floating text TwigComponent: remove floating text Oct 9, 2025
@alexislefebvre alexislefebvre changed the title TwigComponent: remove floating text [TwigComponent] remove floating text Oct 9, 2025
@Kocal
Copy link
Member

Kocal commented Oct 10, 2025

I think the current goal of this text is to behave like a <figcaption>, thus I suggest to keep it, but improve its current display.

cc @javiereguiluz, do you know if Symfony RST is able to handle <figure> and <figcaption>? Thanks

@javiereguiluz
Copy link
Member

No. We just generate simple <img>. For example, this RST code:

.. image:: /_images/components/console/completion.gif
    :alt: The terminal completes the command name "secrets:remove" and the argument "SOME_OTHER_SECRET".

When rendering the HTML page (https://symfony.com/doc/current/console.html) it generates this HTML code:

<img src="/doc/7.3/_images/completion.gif" alt="The terminal completes the command name &quot;secrets:remove&quot; and the argument &quot;SOME_OTHER_SECRET&quot;.">

@Kocal
Copy link
Member

Kocal commented Oct 10, 2025

Alright, thanks!

@Kocal Kocal changed the title [TwigComponent] remove floating text [TwigComponent] Remove floating text in documentation Oct 10, 2025
@Kocal
Copy link
Member

Kocal commented Oct 10, 2025

Thank you @alexislefebvre.

@Kocal Kocal merged commit 7b19b30 into symfony:2.x Oct 10, 2025
2 checks passed
@alexislefebvre alexislefebvre deleted the patch-3 branch October 10, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation Status: Needs Review Needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants