Fix InteractsWithTwigComponents not being able to render blocks when variable scope is limited (cache friendlier solution with limitations)#3212
Open
janopae wants to merge 2 commits intosymfony:2.xfrom
Conversation
… when variable scope is limited in tests
…e is limited as long as `outerScope` is included This is more cache-friendly than to inline the content of the block into the Twig template. But it requires Twig component authors to allow the `outerScope` variable in their blocks.
janopae
changed the title
Member
|
This is problematic to me, as using outerScope really does change the runtime code and makes it in my eyes too different of what would happen in production. Also at best it would not bring added value for most users.. at worst it could be causing problems with outerScope or any change we do around its implementation. I'm pretty sure we can find a way to help you in that very specific need without impacting every other tests out there .. |
Kocal
added
Status: Waiting feedback
carsonbot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #3211 which should be more cache-friendly. Has the limitation that it requires components to allow the
outerScopevariable in blocks they define.