[Validator] Allow checkMX() to return false when $host is empty

apetitpa · fabpot · commit 6fad799dcaf3 · 2017-04-05T11:10:12.000-07:00
| Q | A |
| --- | --- |
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #22106 |
| License | MIT |
| Doc PR | n/a |
diff --git a/Constraints/EmailValidator.php b/Constraints/EmailValidator.php
@@ -138,6 +138,10 @@ public function validate($value, Constraint $constraint)
      */
     private function checkMX($host)
     {
+        if (null === $host || '' === $host) {
+            return false;
+        }
+
         return checkdnsrr($host, 'MX');
     }
 

Original file line number	Diff line number	Diff line change
`@@ -138,6 +138,10 @@ public function validate($value, Constraint $constraint)`
`138`	`138`	`*/`
`139`	`139`	`private function checkMX($host)`
`140`	`140`	`{`
	`141`	`+ if (null === $host \|\| '' === $host) {`
	`142`	`+ return false;`
	`143`	`+ }`
	`144`	`+`
`141`	`145`	`return checkdnsrr($host, 'MX');`
`142`	`146`	`}`
`143`	`147`