Set constant visibility in tests to private where possible.

derrabus · derrabus · commit a46669c6f537 · 2020-10-31T23:44:29.000+01:00
diff --git a/Tests/Mapping/ClassMetadataTest.php b/Tests/Mapping/ClassMetadataTest.php
@@ -24,10 +24,10 @@
 
 class ClassMetadataTest extends TestCase
 {
-    const CLASSNAME = 'Symfony\Component\Validator\Tests\Fixtures\Entity';
-    const PARENTCLASS = 'Symfony\Component\Validator\Tests\Fixtures\EntityParent';
-    const PROVIDERCLASS = 'Symfony\Component\Validator\Tests\Fixtures\GroupSequenceProviderEntity';
-    const PROVIDERCHILDCLASS = 'Symfony\Component\Validator\Tests\Fixtures\GroupSequenceProviderChildEntity';
+    private const CLASSNAME = 'Symfony\Component\Validator\Tests\Fixtures\Entity';
+    private const PARENTCLASS = 'Symfony\Component\Validator\Tests\Fixtures\EntityParent';
+    private const PROVIDERCLASS = 'Symfony\Component\Validator\Tests\Fixtures\GroupSequenceProviderEntity';
+    private const PROVIDERCHILDCLASS = 'Symfony\Component\Validator\Tests\Fixtures\GroupSequenceProviderChildEntity';
 
     protected $metadata;
 
diff --git a/Tests/Mapping/Factory/LazyLoadingMetadataFactoryTest.php b/Tests/Mapping/Factory/LazyLoadingMetadataFactoryTest.php
@@ -26,11 +26,9 @@
 
 class LazyLoadingMetadataFactoryTest extends TestCase
 {
-    const CLASS_NAME = 'Symfony\Component\Validator\Tests\Fixtures\Entity';
-    const PARENT_CLASS = 'Symfony\Component\Validator\Tests\Fixtures\EntityParent';
-    const INTERFACE_A_CLASS = 'Symfony\Component\Validator\Tests\Fixtures\EntityInterfaceA';
-    const INTERFACE_B_CLASS = 'Symfony\Component\Validator\Tests\Fixtures\EntityInterfaceB';
-    const PARENT_INTERFACE_CLASS = 'Symfony\Component\Validator\Tests\Fixtures\EntityParentInterface';
+    private const CLASS_NAME = 'Symfony\Component\Validator\Tests\Fixtures\Entity';
+    private const PARENT_CLASS = 'Symfony\Component\Validator\Tests\Fixtures\EntityParent';
+    private const INTERFACE_A_CLASS = 'Symfony\Component\Validator\Tests\Fixtures\EntityInterfaceA';
 
     public function testLoadClassMetadataWithInterface()
     {
diff --git a/Tests/Mapping/GetterMetadataTest.php b/Tests/Mapping/GetterMetadataTest.php
@@ -17,7 +17,7 @@
 
 class GetterMetadataTest extends TestCase
 {
-    const CLASSNAME = 'Symfony\Component\Validator\Tests\Fixtures\Entity';
+    private const CLASSNAME = 'Symfony\Component\Validator\Tests\Fixtures\Entity';
 
     public function testInvalidPropertyName()
     {
diff --git a/Tests/Mapping/PropertyMetadataTest.php b/Tests/Mapping/PropertyMetadataTest.php
@@ -19,10 +19,10 @@
 
 class PropertyMetadataTest extends TestCase
 {
-    const CLASSNAME = 'Symfony\Component\Validator\Tests\Fixtures\Entity';
-    const CLASSNAME_74 = 'Symfony\Component\Validator\Tests\Fixtures\Entity_74';
-    const CLASSNAME_74_PROXY = 'Symfony\Component\Validator\Tests\Fixtures\Entity_74_Proxy';
-    const PARENTCLASS = 'Symfony\Component\Validator\Tests\Fixtures\EntityParent';
+    private const CLASSNAME = 'Symfony\Component\Validator\Tests\Fixtures\Entity';
+    private const CLASSNAME_74 = 'Symfony\Component\Validator\Tests\Fixtures\Entity_74';
+    private const CLASSNAME_74_PROXY = 'Symfony\Component\Validator\Tests\Fixtures\Entity_74_Proxy';
+    private const PARENTCLASS = 'Symfony\Component\Validator\Tests\Fixtures\EntityParent';
 
     public function testInvalidPropertyName()
     {

Original file line number	Diff line number	Diff line change
`@@ -26,11 +26,9 @@`
`26`	`26`
`27`	`27`	`class LazyLoadingMetadataFactoryTest extends TestCase`
`28`	`28`	`{`
`29`		`- const CLASS_NAME = 'Symfony\Component\Validator\Tests\Fixtures\Entity';`
`30`		`- const PARENT_CLASS = 'Symfony\Component\Validator\Tests\Fixtures\EntityParent';`
`31`		`- const INTERFACE_A_CLASS = 'Symfony\Component\Validator\Tests\Fixtures\EntityInterfaceA';`
`32`		`- const INTERFACE_B_CLASS = 'Symfony\Component\Validator\Tests\Fixtures\EntityInterfaceB';`
`33`		`- const PARENT_INTERFACE_CLASS = 'Symfony\Component\Validator\Tests\Fixtures\EntityParentInterface';`
	`29`	`+ private const CLASS_NAME = 'Symfony\Component\Validator\Tests\Fixtures\Entity';`
	`30`	`+ private const PARENT_CLASS = 'Symfony\Component\Validator\Tests\Fixtures\EntityParent';`
	`31`	`+ private const INTERFACE_A_CLASS = 'Symfony\Component\Validator\Tests\Fixtures\EntityInterfaceA';`
`34`	`32`
`35`	`33`	`public function testLoadClassMetadataWithInterface()`
`36`	`34`	`{`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@`
`17`	`17`
`18`	`18`	`class GetterMetadataTest extends TestCase`
`19`	`19`	`{`
`20`		`- const CLASSNAME = 'Symfony\Component\Validator\Tests\Fixtures\Entity';`
	`20`	`+ private const CLASSNAME = 'Symfony\Component\Validator\Tests\Fixtures\Entity';`
`21`	`21`
`22`	`22`	`public function testInvalidPropertyName()`
`23`	`23`	`{`
Original file line number	Diff line number	Diff line change
`@@ -19,10 +19,10 @@`
`19`	`19`
`20`	`20`	`class PropertyMetadataTest extends TestCase`
`21`	`21`	`{`
`22`		`- const CLASSNAME = 'Symfony\Component\Validator\Tests\Fixtures\Entity';`
`23`		`- const CLASSNAME_74 = 'Symfony\Component\Validator\Tests\Fixtures\Entity_74';`
`24`		`- const CLASSNAME_74_PROXY = 'Symfony\Component\Validator\Tests\Fixtures\Entity_74_Proxy';`
`25`		`- const PARENTCLASS = 'Symfony\Component\Validator\Tests\Fixtures\EntityParent';`
	`22`	`+ private const CLASSNAME = 'Symfony\Component\Validator\Tests\Fixtures\Entity';`
	`23`	`+ private const CLASSNAME_74 = 'Symfony\Component\Validator\Tests\Fixtures\Entity_74';`
	`24`	`+ private const CLASSNAME_74_PROXY = 'Symfony\Component\Validator\Tests\Fixtures\Entity_74_Proxy';`
	`25`	`+ private const PARENTCLASS = 'Symfony\Component\Validator\Tests\Fixtures\EntityParent';`
`26`	`26`
`27`	`27`	`public function testInvalidPropertyName()`
`28`	`28`	`{`