fix single upload for using with liip_imagine#78
Open
calvera wants to merge 1 commit intosymfony2admingenerator:masterfrom
Open
fix single upload for using with liip_imagine#78calvera wants to merge 1 commit intosymfony2admingenerator:masterfrom
calvera wants to merge 1 commit intosymfony2admingenerator:masterfrom
Conversation
ioleo
approved these changes
May 31, 2017
Member
ioleo
left a comment
ioleo
left a comment
There was a problem hiding this comment.
Which version of LiipImagine does this PR fix? Maybe should add info about version constraint in README?
bobvandevijver
requested changes
May 31, 2017
Member
bobvandevijver
left a comment
bobvandevijver
left a comment
There was a problem hiding this comment.
Please do not use the complete container reference. You are only using a parameter, you can inject only that one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in case of using liip_imagine, single upload type thought that file does not exist