You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
bug symfony#53525 [Messenger] [AMQP] Throw exception on nack callback (kvrushifa)
This PR was squashed before being merged into the 5.4 branch.
Discussion
----------
[Messenger] [AMQP] Throw exception on `nack` callback
| Q | A
| ------------- | ---
| Branch? | 5.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Issues | Fixsymfony#53229
| License | MIT
If the channel is in confirm mode, it is currently not possible to determine if a message has been nack'ed. By throwing an exception within the confirm callback, it is at least possible to react to it.
Return false is not needed to end the wait loop, [since the amqp ext checks for exceptions](https://github.com/php-amqp/php-amqp/blob/e58ac221e317c840ee06f7731e0dc76c7d6a431a/amqp_methods_handling.c#L249).
Commits
-------
6ed35b6 [Messenger] [AMQP] Throw exception on `nack` callback
0 commit comments