Skip to content

Warnings are errors for everything #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaron-skydio wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Warnings are errors for everything #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions symforce/benchmarks/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,10 @@ function(add_matrix_multiplication_benchmark matrix_name)
matrix_multiplication/gen/matrix_multiplication_benchmark_${matrix_name}.cc
)

target_compile_options(matrix_multiplication_benchmark_${matrix_name}
PRIVATE ${SYMFORCE_COMPILE_OPTIONS}
)

target_link_libraries(
matrix_multiplication_benchmark_${matrix_name}
Catch2::Catch2WithMain
Expand All @@ -138,6 +142,8 @@ add_executable(
inverse_compose_jacobian/inverse_compose_jacobian_benchmark.cc
)

target_compile_options(inverse_compose_jacobian_benchmark PRIVATE ${SYMFORCE_COMPILE_OPTIONS})

find_package(Sophus REQUIRED)
target_link_libraries(
inverse_compose_jacobian_benchmark
Expand All @@ -159,6 +165,8 @@ add_executable(
robot_3d_localization/robot_3d_localization_benchmark.cc
)

target_compile_options(robot_3d_localization_benchmark PRIVATE ${SYMFORCE_COMPILE_OPTIONS})

target_link_libraries(
robot_3d_localization_benchmark
gtsam
Expand Down
2 changes: 2 additions & 0 deletions symforce/examples/bundle_adjustment_in_the_large/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ add_executable(
bundle_adjustment_in_the_large.cc
)

target_compile_options(bundle_adjustment_in_the_large_example PRIVATE ${SYMFORCE_COMPILE_OPTIONS})

target_link_libraries(
bundle_adjustment_in_the_large_example
symforce_gen
Expand Down
1 change: 1 addition & 0 deletions test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ foreach(SOURCE_FILE ${SYMFORCE_TEST_CC_SOURCES})
set_target_properties(${TARGET_NAME} PROPERTIES OUTPUT_NAME ${BINARY_NAME})
set_target_properties(${TARGET_NAME} PROPERTIES TEST_NAME ${TEST_NAME})
set_target_properties(${TARGET_NAME} PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin)
target_compile_options(${TARGET_NAME} PRIVATE ${SYMFORCE_COMPILE_OPTIONS})
target_link_libraries(
${TARGET_NAME}
symforce_gen
Expand Down